Skip to content
This repository has been archived by the owner on Aug 27, 2024. It is now read-only.

chore: support net8.0 version #313

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

stijnmoreels
Copy link
Member

@stijnmoreels stijnmoreels commented Mar 18, 2024

Fully support .NET 8 w/ the most recent Arcus packages.

Closes #295

@stijnmoreels stijnmoreels requested a review from fgheysels as a code owner March 18, 2024 07:46
@stijnmoreels stijnmoreels added this to the v4.0 milestone Mar 18, 2024
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for arcus-eventgrid canceled.

Name Link
🔨 Latest commit f76edd2
🔍 Latest deploy log https://app.netlify.com/sites/arcus-eventgrid/deploys/65f7f542f2e0a5000851e2d0

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 87.34%. Comparing base (3d2e7ec) to head (f76edd2).
Report is 1 commits behind head on main.

Files Patch % Lines
....Testing/Infrastructure/Hosts/EventConsumerHost.cs 89.28% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
- Coverage   87.44%   87.34%   -0.11%     
==========================================
  Files          15       15              
  Lines         733      727       -6     
  Branches       50       53       +3     
==========================================
- Hits          641      635       -6     
+ Misses         74       73       -1     
- Partials       18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stijnmoreels
Copy link
Member Author

@fgheysels , best to take this PR as priority next time you have Arcus-time. 😉

@fgheysels fgheysels merged commit a8315a4 into arcus-azure:main Apr 27, 2024
17 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary NoOpLogger in Arcus.EventGrid.Testing
2 participants