Ruff django rule

main/templatetags/details_link.py

@@ -3,6 +3,7 @@
 
 from django import template
 from django.conf import settings
+from django.utils.html import format_html
 
 from main.templatetags import pgp
 from main.utils import gitlab_project_name_to_path
@@ -18,9 +19,10 @@ def link_encode(url, query):
     return "%s?%s" % (url, data)
 
 
-@register.inclusion_tag('packages/details_link.html')
+@register.simple_tag
 def details_link(pkg):
-    return {'pkg': pkg}
+    link = '<a href="%s" title="View package details for %s">%s</a>'
+    return format_html(link % (pkg.get_absolute_url(), pkg.pkgname, pkg.pkgname))
 
 
 @register.simple_tag

packages/views/display.py

@@ -128,13 +128,15 @@ def details(request, name='', repo='', arch=''):
             pkg = Package.objects.select_related(
                 'arch', 'repo', 'packager').get(pkgname=name,
                                                 repo=repo_obj, arch=arch_obj)
-            rbstatus = None
-            try:
-                rbstatus = RebuilderdStatus.objects.get(pkg=pkg)
-            except RebuilderdStatus.DoesNotExist:
-                pass
             if request.method == 'HEAD':
                 return empty_response()
+
+            rbstatus = None
+            if request.user.is_authenticated:
+                try:
+                    rbstatus = RebuilderdStatus.objects.get(pkg=pkg)
+                except RebuilderdStatus.DoesNotExist:
+                    pass
             return render(request, 'packages/details.html', {'pkg': pkg, 'rbstatus': rbstatus,
                           'notreproducible': rbstatus.status == RebuilderdStatus.BAD if rbstatus else False})
         except Package.DoesNotExist:

public/views.py

@@ -93,7 +93,7 @@ def feeds(request):
 def keys(request):
     profile_ids = UserProfile.allowed_repos.through.objects.values('userprofile_id')
     users = User.objects.filter(
-            is_active=True, userprofile__id__in=profile_ids).order_by('first_name', 'last_name')
+            is_active=True, userprofile__id__in=profile_ids).order_by('first_name', 'last_name').select_related('userprofile')
     user_key_ids = frozenset(user.userprofile.pgp_key[-16:] for user in users
             if user.userprofile.pgp_key)
 

ruff.toml

@@ -5,6 +5,7 @@ select = [
     "A",       # flake8-builtins
     "B",       # flake8-bugbear
     "C4",      # flake8-comprehensions
+    "DJ",      # flake8-django
     "E",       # pycodestyle
     "F",       # pyflakes
     "G",       # flake8-logging-format
@@ -27,4 +28,9 @@ ignore = [
     "E731", # Do not assign a `lambda` expression, use a `def`
     "B904", # Within an `except` clause, raise exceptions with `raise ... from err`
     "RUF012", # Mutable class attributes should be annotated with `typing.ClassVar`
+    # TODO: add these one by one
+    "DJ001", # Avoid using `null=True` on string-based fields such as `CharField`
+    "DJ006", # Do not use `exclude` with `ModelForm`, use `fields` instead
+    "DJ008", # Model does not define `__str__` method
+    "DJ012", # Order of model's inner classes, methods, and fields does not follow the Django Style Guide: `Meta` class should come before `get_absolute_url`
 ]