Fix name fallback for Archestra get tools#3223
Fix name fallback for Archestra get tools#3223yodakohl wants to merge 4 commits intoarchestra-ai:mainfrom
Conversation
|
Codex seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
📊 Reputation Summary
How is the score calculated? Read about it in the Reputation Bot repository 🤖 |
|
could you please add an input parameter to search by name? |
joeyorlando
left a comment
There was a problem hiding this comment.
hey 👋 thanks for the contribution - one small comment about reusability of the util function
| function isUuid(value: string): boolean { | ||
| return /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i.test( | ||
| value, | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
do you mind extracting isUuid (backend/src/models/interaction.ts) and isValidUUID (backend/src/routes/chatops.ts) out into a shared util and reusing in those three spots?
|
Assigned the issue to you, could you please providea quick screencast where all that tools are functional, as per issue description:
|
|
there is linting issue in the code: |
/claim #3214
Fixes the shared get-tool path so
get_mcp_gateway,get_agent, andget_llm_proxyno longer crash when the caller passes a human-readable name inid.What changed:
AgentModel.findByIdidvalues now fall back to the existing personal-agent name search pathWhy:
args.idstraight into a UUID lookupn8n workflow: Grafana exporter, PostgreSQL rejects the UUID comparison and the user gets a generic unexpected error