Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let TypeError propagate from tile functions #11805 #11807

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

jacobtylerwalls
Copy link
Member

Catching this could cause other functions to not run by breaking out of the loop.
Closes #11805

👋 @aj-he you might be interested as I see in #8472 you elevated the info log to a warning. A hard fail would be nice here, no?

Catching this could cause other functions to not run.
@aj-he
Copy link
Contributor

aj-he commented Feb 24, 2025

@jacobtylerwalls - A key thing for us it to be able to trace function failure through logging as we have quite a few functions that interface other internal services. I suspect that this was changed to ensure we could see this clearer in our monitoring when the ArcGIS add-in failed to write through the nodevalue api.

I'm happy for the typeerror to be explicitly removed, but could there be a level of logging on unhandled errors to allow the issue to be traced?

@jacobtylerwalls
Copy link
Member Author

Great idea. We could just logger.error(exception) inside the custom 500 view added in #11784.

@jacobtylerwalls
Copy link
Member Author

I'll test it, I have a feeling it might be duplicative with the existing logging to arches.log configured in LOGGING setting.

@jacobtylerwalls
Copy link
Member Author

I'll bounce this idea to a new issue, I'm surprised we didn't have it configured by default.

@jacobtylerwalls
Copy link
Member Author

See #11813

Copy link
Contributor

@aj-he aj-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobtylerwalls, given the associated change to catch the errors I'm happy to approve. Once we upgrade to 8 we'll see if there are any issues that reappear and address appropriately.

@jacobtylerwalls jacobtylerwalls merged commit 4b5e67c into dev/8.0.x Mar 4, 2025
7 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/dont-catch-function-type-errors branch March 4, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tile functions catch TypeError too widely
2 participants