Restore custom error views (but return JSON where desired) #11722 #11784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
Feb 11, 2025
| def looks_like_api_call(request): | ||
| known_api_paths_without_api_signposting = [ | ||
| # Until these are renamed for consistency, just list them. | ||
| "arches.app.views.workflow_history", |
There was a problem hiding this comment.
We can add more as we find them, but I'm considering it out of scope to audit everything right now: that's a lot of views to analyze. See next comment for why this one is here.
Comment on lines
-86
to
+89
| self.assertEqual(response.status_code, 403) | ||
| self.assertIn(b"Forbidden", response.content) | ||
| self.assertContains( | ||
| response, "Permission Denied", status_code=HTTPStatus.FORBIDDEN | ||
| ) |
There was a problem hiding this comment.
Because this error condition was already tested, we caught an example of HTML where we should have sent JSON.
Before:
\n<!doctype html>\n<html lang="en">\n<head>\n <title>403 Forbidden</title>\n</head>\n<body>\n <h1>403 Forbidden</h1><p></p>\n</body>\n</html>\nAfter:
{"message": "Permission Denied", "status": "false", "success": false, "title": "Request Failed"}
jacobtylerwalls
commented
Feb 13, 2025
| @@ -781,9 +781,13 @@ | |||
| api.SpatialView.as_view(), | |||
| name="spatialview_api", | |||
| ), | |||
| re_path("^api", api.API404.as_view(), name="api_404"), | |||
There was a problem hiding this comment.
Now we don't need this anymore to handle errors, which is good, because it was too fragile in practice (sneaky failures depending on the order in which you included your other URLs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
This PR addresses two issues:
.json()on a response body won't throw when they get an HTML response from the generic (or customized) error view.Issues Solved
Closes #11722
Checklist
Ticket Background