Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out a helper for calculating next tile sort order #11762

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

jacobtylerwalls
Copy link
Member

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

This allows access to the calculation for tile sort order without having to call Tile.save(), e.g. if planning to call TileModel.objects.create(**data) instead.

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Ticket Background

@jacobtylerwalls jacobtylerwalls requested a review from njkim January 31, 2025 23:24
# TODO: this is not updating update_fields in kwargs
# Fix when adding user argument to Resource.save().
add_to_update_fields(kwargs, "principaluser_id")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I no longer plan to suggest the change in that TODO, so just rolling in the fix now.

Copy link
Collaborator

@njkim njkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@njkim njkim merged commit e678323 into dev/8.0.x Feb 6, 2025
7 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/factor-out-next-tile-sort-order branch February 6, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants