Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alt text on image placeholder #10455 #11761

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Add alt text on image placeholder #10455 #11761

merged 2 commits into from
Feb 3, 2025

Conversation

jacobtylerwalls
Copy link
Member

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Issues Solved

Closes #10455

Testing instructions

Create a file-list node in the card designer, and view the report. Inspect the accessibility properties on the image.

SDScandrettKint
SDScandrettKint approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@SDScandrettKint SDScandrettKint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works nicely!

@jacobtylerwalls
Copy link
Member Author

Thanks for reviewing.

@jacobtylerwalls jacobtylerwalls merged commit d559dfd into dev/8.0.x Feb 3, 2025
7 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/image-placeholder-alt branch February 3, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SDScandrettKint SDScandrettKint SDScandrettKint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an alt text for "Photo not available" placeholder image
2 participants
@jacobtylerwalls @SDScandrettKint