Return blank tiles from get_tile_data() #10829

[jacobtylerwalls]

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Return blank tiles (holding only None values) from get_tile_data() rather than returning an implicit None. For example, return {node_id: None} rather than None.

Datatypes often drill into the result of get_type_data() expecting a dict, and do not check for None. (Perhaps they should, since there is still a code path that could return None after logging an exception. Or, we could elevate that logged exception to a runtime exception, but that's outside the scope here.)

Tiles might hold only None if a tile is added for a resource and then edited to remove all values. Or they might have been created in a data migration (#9704, 7.5.0).

Refs 4b02d35

History

4b02d35 changed the if/else logic so that tiles with only falsy values log an exception and return None implicitly (7.5.0)
e4a519e tightened that up to "only None values" to exempt falsy values like [] in the file-list datatype. (7.5.0)
be7a130 removed the logged exception for blank tiles but kept the implicit None return (7.5.2)

Targeting dev/7.5.x as this is a regression in 7.5.0.

Issues Solved

Closes #10829

Checklist

• Unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Ticket Background

• Sponsored by: Farallon
• Found by: @aj-he
• Tested by: @jacobtylerwalls

[aj-he]

Seems to have fixed the initial error. I am running some load package tests.

[aj-he]

this fixes the issue