Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 5613_notification_types reversible #10772 #10773

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

jacobtylerwalls
Copy link
Member

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

The table referenced here is deleted in the same migration, so deleting an individual row is not needed. Prevents error about "pending trigger events".

Issues Solved

Closes #10772

@jacobtylerwalls jacobtylerwalls linked an issue Apr 15, 2024 that may be closed by this pull request
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jacobtylerwalls jacobtylerwalls merged commit 83bf37c into dev/7.6.x Apr 18, 2024
4 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/reverse-notif-type branch April 18, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5613_notification_type can't be reversed
2 participants