Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10767 enforce search filter sortorder #10768

Closed
wants to merge 2 commits into from

Conversation

whatisgalen
Copy link
Member

@whatisgalen whatisgalen commented Apr 13, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

The sortorder of search filters is preserved on search load when a new queryObject gets created. However as soon as it is mutated, search filter order per each's search_component.sortorder is no longer maintained. This PR ensures that the queryObject (renamed so since that's what it is in the ajax request) enforces search filter sortorder prior to sending to the backend.

Issues Solved

#10767

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Ticket Background

Further comments

@whatisgalen whatisgalen marked this pull request as draft May 7, 2024 01:21
@chiatt chiatt deleted the 10767_enforce_search_filter_sortorder branch August 6, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant