-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves node modules to root #10758
Moves node modules to root #10758
Conversation
…nto 10757-cbyrd-move-node_modules-to-root
…nto 10757-cbyrd-move-node_modules-to-root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! Tested with AfS and disco, including with disco's existing docker setup, and only ran into two instances of this issue:
| throw new Error("Module build failed (from ./node_modules/css-loader/dist/cjs.js):\nError: Can't resolve '../../node_modules/@uppy/progress-bar/dist/style.min.css' in '/web_root/arches-for-science/arches_for_science/media/css'
Doubt that we need to solve that on this PR.
Left some feedback for a little polish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the updates!
Types of changes
Description of Change
Moves
node_modules
andwebpack
directories to root in both arches-core and projectsIssues Solved
#10757