Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persist function_x_graph id, re #10750 #10751

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

apeters
Copy link
Member

@apeters apeters commented Apr 11, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Issues Solved

#10750

Checklist

  • Unit tests pass with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Ticket Background

  • Sponsored by:
  • Found by: @
  • Tested by: @
  • Designed by: @

Further comments

@apeters
Copy link
Member Author

apeters commented Apr 11, 2024

To test this, import a graph that includes a reference to a functions_x_graphs.
Then export that graph and compare the .json to the graph you just imported. Notice that before the change the functions_x_graphs id changed and after the fix is has the same id as what was imported.

Copy link
Member

@johnatawnclementawn johnatawnclementawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

@johnatawnclementawn johnatawnclementawn merged commit 467ba8a into dev/7.6.x Apr 12, 2024
4 checks passed
@johnatawnclementawn johnatawnclementawn deleted the 10750_persist_function_x_graph_id branch April 12, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants