Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetically sort graphs by name in search Resource Type filter #10647

Conversation

SDScandrettKint
Copy link
Member

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Adds a function that sorts self.resourceModels in resource-type-filter.js based on the graph name, using the javascript localeCompare method.

Issues Solved

#10646

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Ticket Background

Further comments

@SDScandrettKint SDScandrettKint changed the title Sort graphs by name in search Resource Type filter Alphabetically sort graphs by name in search Resource Type filter Mar 7, 2024
@chiatt chiatt self-assigned this May 31, 2024
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add a line in the release notes for this fix?

@bferguso
Copy link
Contributor

@chiatt - Is there any way we could cherry pick this into the next 7.5.x release too?

@SDScandrettKint
Copy link
Member Author

Closed and replaced with #11062 targetting dev/7.5.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants