Skip to content

Commit

Permalink
simplify control flow for bulk_delete.delete_resources, re #10781
Browse files Browse the repository at this point in the history
  • Loading branch information
whatisgalen committed May 3, 2024
1 parent d1d1bf3 commit 67e4c18
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions arches/app/etl_modules/bulk_data_deletion.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,12 +135,10 @@ def delete_resources(self, userid, loadid, graphid=None, resourceids=None, verbo
deleted_count = 0
user = User.objects.get(id=userid) if userid else {}
try:
if resourceids and graphid:
resources = Resource.objects.filter(graph_id=graphid).filter(pk__in=resourceids)
if resourceids:
resources = Resource.objects.filter(pk__in=resourceids)
elif graphid:
resources = Resource.objects.filter(graph_id=graphid)
elif resourceids:
resources = Resource.objects.filter(pk__in=resourceids)
else:
result["message"] = _("Unable to bulk delete resources as no graphid or resourceids specified.")
result["deleted_count"] = 0
Expand Down

0 comments on commit 67e4c18

Please sign in to comment.