Polish styles, text, signposting, localize metadata label

archesproject · Apr 25, 2024 · 2178716 · 2178716
1 parent e9f65a7
commit 2178716
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 2 deletions.
diff --git a/arches/app/src/components/ControlledListManager/ItemEditor.vue b/arches/app/src/components/ControlledListManager/ItemEditor.vue
@@ -104,6 +104,12 @@ const addHeader = (event: FileUploadBeforeSendEvent) => {
                 :alt="image.metadata[0]?.alt"
                 width="200"
             >
+            <span
+                v-if="!item.images.length"
+                :style="{ fontSize: 'small'}"
+            >
+                {{ $gettext("No images.") }}
+            </span>
         </div>
         <FileUpload
             accept="image/*"

diff --git a/arches/app/src/components/ControlledListManager/LabelEditor.vue b/arches/app/src/components/ControlledListManager/LabelEditor.vue
@@ -133,7 +133,7 @@ const languageName = (code: string) => {
             <Column
                 field="language_id"
                 :header="$gettext('Language')"
-                style="width: 10%; min-width: 8rem; height: 4rem;"
+                style="width: 10%; min-width: 8rem; height: 4rem; padding-left: 1rem;"
             >
                 <template #editor="{ data, field }">
                     <Dropdown

diff --git a/arches/app/src/components/ControlledListManager/ListHeader.vue b/arches/app/src/components/ControlledListManager/ListHeader.vue
@@ -18,11 +18,13 @@ const heading = computed(() => {
         return $gettext(
             "List Editor > %{listName}",
             { listName: displayedRow.value.name },
+            true, // disable HTML escaping: RDM Admins are trusted users
         );
     }
     return $gettext(
         "Item Editor > %{bestLabel}",
         { bestLabel: bestLabel(displayedRow.value, selectedLanguage.value.code).value },
+        true, // disable HTML escaping: RDM Admins are trusted users
     );
 });
 </script>

diff --git a/arches/app/src/components/ControlledListManager/ReferenceNodeLink.vue b/arches/app/src/components/ControlledListManager/ReferenceNodeLink.vue
@@ -24,7 +24,7 @@ const { $gettext } = useGettext();
                 class="fa fa-reply"
                 aria-hidden="true"
             />
-            {{ $gettext("Edit node") }}
+            {{ $gettext("Edit graph") }}
         </a>
     </span>
 </template>

diff --git a/arches/app/src/types/ControlledListManager.ts b/arches/app/src/types/ControlledListManager.ts
@@ -21,6 +21,7 @@ export type ControlledListItemImageMetadata = {
     controlled_list_image_id: string,
     language_id: string,
     metadata_type: string,
+    metadata_label: string,
 };
 
 export type ControlledListItemImage = {

diff --git a/arches/app/views/controlled_lists.py b/arches/app/views/controlled_lists.py
@@ -140,9 +140,13 @@ def serialize(obj, depth_map=None, flat=False):
                 ]
             }
         case ControlledListItemImageMetadata():
+            choices = ControlledListItemImageMetadata.MetadataChoices
             return {
                 field: str(value)
                 for (field, value) in vars(obj).items() if not field.startswith("_")
+            } | {
+                # Get localized label for metadata type
+                "metadata_label": str(choices(obj.metadata_type).label)
             }