Skip to content

Conversation

@ZR233
Copy link
Contributor

@ZR233 ZR233 commented Aug 18, 2025

This pull request updates dependencies and refactors code to use new versions and types from the axvmconfig, axaddrspace, and axdevice_base crates. The main changes include switching from git-based dependencies to versioned crates, updating type names for emulated device types, and minor improvements to device configuration handling.

Dependency updates:

  • Changed axvmconfig, axaddrspace, and axdevice_base dependencies in Cargo.toml from git repositories to versioned crates, improving stability and reproducibility.

Refactoring for new types:

  • Replaced usage of EmuDeviceType with EmulatedDeviceType throughout src/device.rs to match updated type definitions in the new axvmconfig crate. [1] [2] [3] [4] [5] [6]
  • Updated imports in src/device.rs to reflect new type locations and remove unused items.

Device configuration handling:

  • Improved argument extraction from cfg_list by using .first() instead of .get(0) for clarity and safety in device initialization. [1] [2]

@aarkegz aarkegz requested review from aarkegz and Copilot August 18, 2025 03:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates three key dependencies from git-based to versioned crates and refactors code to use updated type names. The changes improve dependency management stability and align with the new type definitions in the updated crates.

  • Updated axvmconfig, axaddrspace, and axdevice_base dependencies from git repositories to version 0.1 crates
  • Replaced EmuDeviceType with EmulatedDeviceType throughout device configuration handling
  • Improved code clarity by using .first() instead of .get(0) for array access

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Cargo.toml Updated three dependencies from git repositories to versioned crates (0.1)
src/device.rs Updated imports and type usage to match new crate versions, replaced deprecated type names

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@ZR233 ZR233 merged commit c4a0965 into master Aug 18, 2025
10 checks passed
@ZR233 ZR233 deleted the dev branch August 18, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants