Skip to content

Conversation

@aarkegz
Copy link
Contributor

@aarkegz aarkegz commented Jul 14, 2025

No description provided.

@aarkegz aarkegz requested review from Copilot and hky1999 July 14, 2025 12:02
@aarkegz aarkegz self-assigned this Jul 14, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for virtual GICv3 (GPPT) devices by extending the device initialization logic and enabling the necessary feature in the GIC crate.

  • Introduce new branches in AxVmDevices::init to handle GPPT Redistributor, Distributor, and ITS based on EmuDeviceType
  • Import PhysAddr and add a 'static bound on AxEmuDevices
  • Enable the vgicv3 feature for the arm_vgic dependency in Cargo.toml

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/device.rs Add match arms for GPPTRedistributor, GPPTDistributor, and GPPTITS, plus static bound and PhysAddr import
Cargo.toml Add features = ["vgicv3"] to the arm_vgic dependency
Comments suppressed due to low confidence (2)

src/device.rs:143

  • [nitpick] Add a brief comment above this block explaining the GPPT Redistributor parameters (cpu_num, stride, pcpu_id) and expected behavior for future maintainers.
                EmuDeviceType::GPPTRedistributor => {

src/device.rs:143

  • Introduce unit or integration tests covering the new GPPT Redistributor, Distributor, and ITS initialization paths to verify MMIO device setup and logging.
                EmuDeviceType::GPPTRedistributor => {

@aarkegz aarkegz merged commit 17d2b01 into master Jul 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants