Skip to content

Commit

Permalink
Fix issue where adding imported addresses has PositionInWalletArray s…
Browse files Browse the repository at this point in the history
…et incorrectly
stequald committed Jun 26, 2017
1 parent cb44169 commit 4aa2cd9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/js/model/TLImportedAddresses.js
Original file line number Diff line number Diff line change
@@ -108,7 +108,7 @@ define(['angular', 'model/TLCoin', 'model/TLWalletJSONKeys', 'model/TLBitcoinJSW
var importedPrivateKeyDict = this.appWallet.addImportedPrivateKey(privateKey, encryptedPrivateKey);
var importedAddressObject = new TLImportedAddress(this.appDelegate, importedPrivateKeyDict);
this.importedAddresses.push(importedAddressObject);
importedAddressObject.setPositionInWalletArray(this.importedAddresses.length - 1);
importedAddressObject.setPositionInWalletArray(this.importedAddresses.length + this.archivedImportedAddresses.length - 1);
this.addressToPositionInWalletArrayDict[importedAddressObject.getPositionInWalletArray()] = importedAddressObject;
var address = TLBitcoinJSWrapper.getAddress(privateKey, this.appWallet.isTestnet());
var indexes = this.addressToIdxDict[address];
@@ -117,23 +117,23 @@ define(['angular', 'model/TLCoin', 'model/TLWalletJSONKeys', 'model/TLBitcoinJSW
this.addressToIdxDict[importedAddressObject.getAddress()] = indexes;
}
indexes.push(this.importedAddresses.length-1);
this.setLabel(importedAddressObject.getDefaultAddressLabel(), this.importedAddresses.length-1);
this.setLabel(importedAddressObject.getDefaultAddressLabel(), importedAddressObject.getPositionInWalletArray());
return importedAddressObject;

This comment has been minimized.

Copy link
@yasarsenturklaz

yasarsenturklaz Dec 20, 2017

is:open is:pr author:yasarsenturklaz archived:false

};

TLImportedAddresses.prototype.addImportedWatchAddress = function(address) {
var importedDict = this.appWallet.addWatchOnlyAddress(address);
var importedAddressObject = new TLImportedAddress(this.appDelegate, importedDict);
this.importedAddresses.push(importedAddressObject);
importedAddressObject.setPositionInWalletArray(this.importedAddresses.length - 1);
importedAddressObject.setPositionInWalletArray(this.importedAddresses.length + this.archivedImportedAddresses.length - 1);
this.addressToPositionInWalletArrayDict[importedAddressObject.getPositionInWalletArray()] = importedAddressObject;
var indexes = this.addressToIdxDict[address];
if (indexes == null) {
indexes = [];
this.addressToIdxDict[address] = indexes;
}
indexes.push(this.importedAddresses.length-1);
this.setLabel(importedAddressObject.getDefaultAddressLabel(), this.importedAddresses.length-1);
this.setLabel(importedAddressObject.getDefaultAddressLabel(), importedAddressObject.getPositionInWalletArray());
return importedAddressObject;
};

0 comments on commit 4aa2cd9

Please sign in to comment.