Adding spectra tests back into carthage friendly base.#30
Open
drekka wants to merge 7 commits intoarcam:developfrom
drekka:feature/Specta-tests
Open
Adding spectra tests back into carthage friendly base.#30drekka wants to merge 7 commits intoarcam:developfrom drekka:feature/Specta-tests
drekka wants to merge 7 commits intoarcam:developfrom
drekka:feature/Specta-tests
Conversation
I've set one header as private to illustrate how that can work.
Added test classes. Added imports where needed. BUild everything as frameworks. Coverted global blocks to C function to fix duplicate symbol issues. All tests green.
Member
|
Thanks for this - I'll take a look at it tomorrow 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You will need to merge the other pull request first.
This request adds the spectra tests into the new carthage project.
I added the tests and dependencies in. Without PCH files, I added missing headers. Which resulted in duplicate symbol issues with the test support headers which declared global blocks. Converting the blocks to C functions. I've not seen blocks used or declare like this before. They appeared to act pretty much like C functions, however I found that there where problems when they where imported in more than one test class.
Anyway, results are all green now.
Not sure if you want to go this direction or not.