fix test.py

[naushniki]

No description provided.

[Copilot]

Pull Request Overview

This PR removes the obsolete test mode parameter and mode‐based boolean flags across several modules to simplify the testing and deployment logic.

• Removed the test_mode parameter and related boolean assignments from test_driver and test.py.
• Removed conditional checks for mode flags in the runner code.
• Removed mode-based flag initialization in the installer configuration.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
release_tester/test_driver.py	Removed test_mode parameter and related boolean flag assignments and formatting updates.
release_tester/test.py	Removed the CLI option for test mode and updated the test_driver invocation accordingly.
release_tester/arangodb/starter/deployments/runner.py	Removed mode flag checks from the runner logic and adjusted progress reporting.
release_tester/arangodb/installers/init.py	Removed the initialization and propagation of mode-based boolean flags.

Comments suppressed due to low confidence (4)

release_tester/test_driver.py:404

• Confirm that the removal of the test_mode parameter and related boolean flags does not adversely affect any downstream logic or logging expectations within run_test.

def run_test(self, deployment_mode, versions: list, run_props: RunProperties):

release_tester/test.py:18

• Ensure that the removal of the '--mode' CLI option is intentional and that any documentation or workflows relying on it have been updated accordingly.

@click.option( ... )

release_tester/arangodb/starter/deployments/runner.py:220

• Verify that the removal of conditions based on mode flags (such as do_starter_test and do_install) does not inadvertently change the intended execution flow in deployment and testing scenarios.

if not self.remote:

release_tester/arangodb/installers/init.py:87

• Double-check that the removal of mode-based flag assignments (do_install, do_uninstall, etc.) from the configuration is fully aligned with the updates in all dependent modules.

self.deployment_mode = deployment_mode

[Copilot]

Pull Request Overview

This PR fixes issues in test.py and propagates related changes throughout the test and upgrade pipelines, ensuring consistent parameter usage and configuration defaults. The changes include updates to keyword argument formatting, adjustments to function signatures and parameter passing in test_driver.run_test, and modifications to configuration flags and defaults.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
release_tester/upgrade.py	Standardizes string quotes and updates run_upgrade keyword arguments.
release_tester/test_driver.py	Removes deprecated test_mode and related flags from run_test, affecting error cleanup.
release_tester/test.py	Removes the click option for mode and updates the run_test call with new parameters.
release_tester/mixed_download_upgrade_test.py	Adapts run_test invocation to the new signature by removing the extra test_mode argument.
release_tester/full_download_upgrade_test.py	Updates run_test call by removing the redundant mode parameter.
release_tester/full_download_test.py	Adjusts run_test invocation to reflect the new signature.
release_tester/cleanup.py	Adds new keyword arguments (is_instrumented, skip) to the cleanup workflow.
release_tester/arangodb/starter/deployments/runner.py	Removes certain conditional checks that previously controlled test execution flow.
release_tester/arangodb/installers/init.py	Re-formats imports and changes the default for use_auto_certs from True to False.

Comments suppressed due to low confidence (5)

release_tester/test_driver.py:513

• The removal of the uninstallation condition in the exception block may affect the cleanup process after errors. Confirm this change is intentional and that error handling remains correct.

if must_uninstall_after_this_run and do_uninstall:

release_tester/arangodb/starter/deployments/runner.py:221

• The condition that previously checked self.cfg.do_starter_test was removed; verify that bypassing this condition does not lead to unintended test execution or side effects.

if not self.remote:

release_tester/arangodb/installers/init.py:367

• The default value for use_auto_certs has changed from True to False. Ensure that this modification aligns with the intended certificate handling strategy.

use_auto_certs: bool = False,

release_tester/full_download_test.py:100

• Verify that the updated run_test call without an explicit test_mode parameter is consistent with the new function signature across all call sites.

results.append(test_driver.run_test("all", [dl_new.cfg.version], props))

release_tester/cleanup.py:52

• Confirm that introducing the 'skip' parameter with a default of False in the cleanup workflow is correct and does not inadvertently bypass essential cleanup steps.

kwargs["skip"] = False