Added emptyAttributeOnError option. #1
Open
robertprice wants to merge 4 commits into
Open
Conversation
…ute if an error occurs instead of potentially retaining an existing date.
… than one date picker was on a page as id has to be unique. Updated the test project to test two dates on a page.
Author
|
Also added a fix to allow more than one instance of the date picker to be on page at the same time. |
…iew is used, the class will have the name and fail. This gives it a unique class so it no longer clashes.
Author
|
Also added a unique id to the classname. This is needed because if used in a ListView it caused the classname to be replicated and it was no longer distinct. |
…me as the input box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emptyAttributeOnError fixes a bug I had where changing a year on an existing date to an empty string would mean the previous date was returned silently and with no error. The change returns an empty value now if a problem occurs with the date.
This functionality is optionally turned on using the emptyAttributeOnError option in the widget. By default this is off and the old behaviour is still enabled.
I have not updated the widget version number so if this pull request is accepted this will need to be bumped and the module rebuilt.