Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST][REF] Move and test functions related to creating scans.tsv for AIBL #1390

Merged
merged 13 commits into from
Jan 28, 2025
Merged

[TEST][REF] Move and test functions related to creating scans.tsv for AIBL #1390

merged 13 commits into from
Jan 28, 2025

Conversation

AliceJoubert
Copy link
Contributor

@AliceJoubert AliceJoubert commented Nov 22, 2024 •
edited
Loading

Close #1352, #1353

@AliceJoubert AliceJoubert self-assigned this Nov 22, 2024
@AliceJoubert AliceJoubert marked this pull request as ready for review December 3, 2024 15:23
NicolasGensollen
NicolasGensollen reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AliceJoubert !

I made a first pass with small comments and suggestions.
Looks good to me but I will take a closer look next week.

clinica/iotools/converters/aibl_to_bids/utils/clinical.py Outdated Show resolved Hide resolved
clinica/iotools/converters/aibl_to_bids/utils/clinical.py Outdated Show resolved Hide resolved
clinica/iotools/converters/aibl_to_bids/utils/clinical.py Outdated Show resolved Hide resolved
clinica/iotools/converters/aibl_to_bids/utils/clinical.py Outdated Show resolved Hide resolved
clinica/iotools/converters/aibl_to_bids/utils/clinical.py Outdated Show resolved Hide resolved
clinica/iotools/converters/aibl_to_bids/utils/clinical.py Outdated Show resolved Hide resolved
clinica/iotools/converters/aibl_to_bids/utils/clinical.py Outdated Show resolved Hide resolved
clinica/iotools/converters/aibl_to_bids/utils/clinical.py Outdated Show resolved Hide resolved
@AliceJoubert
Copy link
Contributor Author

Thanks for the review @NicolasGensollen ! Do you see anything else ?

NicolasGensollen
NicolasGensollen reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AliceJoubert !

Besides this small point, the PR LGTM.

clinica/iotools/converters/aibl_to_bids/utils/clinical.py Outdated Show resolved Hide resolved
NicolasGensollen
NicolasGensollen approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@NicolasGensollen NicolasGensollen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AliceJoubert !

@NicolasGensollen NicolasGensollen merged commit 424b25d into aramis-lab:dev Jan 28, 2025
12 of 14 checks passed
@NicolasGensollen NicolasGensollen mentioned this pull request Jan 28, 2025
Closed
@AliceJoubert AliceJoubert deleted the test_aibl_scans branch January 28, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasGensollen NicolasGensollen NicolasGensollen approved these changes

Assignees

@AliceJoubert AliceJoubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REF][TEST] AIBL-to-BIDS : add tests for creating scans.tsv functions
2 participants
@AliceJoubert @NicolasGensollen