Conversation
- auth chain ids vs labelled chain ids - add a test that confims this
…gnments-auth-labelling
jandom
added
the
safe-to-test
| class TestQueryColabfoldMsaServer: | ||
| """Functional test — hits real ColabFold API (~30-60s).""" | ||
|
|
||
| def test_barnase_with_templates(self, tmp_path): |
There was a problem hiding this comment.
I bet we could reuse the ColabFold mmseqs mock itself :
Mock definition: https://github.com/sokrypton/ColabFold/blob/main/tests/mock.py#L109
Usage: https://github.com/sokrypton/ColabFold/blob/9712f2ff262d3977d571919317e06cc96c29cd95/tests/test_msa.py#L7
That would probably be the cleanest way to handle it.
There was a problem hiding this comment.
We would have to vendor it though :/ Not ideal – ColabFold is a very bulk dep to add, i'd rather avoid it
There was a problem hiding this comment.
We've also modified their code a fair bit, i think
There was a problem hiding this comment.
Hey, there @jnwei let me re-vive this PR – I think we can do the pytest-VCR approach to these tests
Ah, script that – we need the full colabfold job to complete. They appear to be using some sort of caching, subsequent calls are instant basically
There was a problem hiding this comment.
Just reviewed the mock code you provided, yeah let's vendor that – it'll be the easiest.
jandom
added
safe-to-test
3 participants
Summary
Quick cleanup of this pretty crucial method and a test
Changes
Related Issues
Testing
Other Notes