Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sdk to upstream branch lightmark/account_abstraction-update-aptos-protos #685

Merged

Conversation

aptos-bot
Copy link
Contributor

This PR updates sdk to new version.

@larry-aptos
Copy link
Collaborator

This is an update from 1.26 for account abstraction

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 11.45038% with 116 lines in your changes missing coverage. Please review.

Project coverage is 49.3%. Comparing base (54bbd61) to head (84e7165).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...dels/user_transaction_models/parquet_signatures.rs 0.0% 61 Missing ⚠️
...gres/models/user_transactions_models/signatures.rs 15.2% 50 Missing ⚠️
...nt_restoration_models/account_restoration_utils.rs 55.5% 4 Missing ⚠️
...er_transaction_models/parquet_user_transactions.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #685     +/-   ##
=======================================
+ Coverage   48.3%   49.3%   +1.0%     
=======================================
  Files        252     252             
  Lines      28535   28641    +106     
=======================================
+ Hits       13788   14139    +351     
+ Misses     14747   14502    -245     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuunlimm
Copy link
Contributor

should we add comments/docstring somewhere to note that it will be implemented later for the external clients.

@larry-aptos
Copy link
Collaborator

should we add comments/docstring somewhere to note that it will be implemented later for the external clients.

do you mean the function_info part?

@larry-aptos larry-aptos force-pushed the lightmark/account_abstraction-update-aptos-protos-update-sdk branch from 0a5fe7d to 84e7165 Compare January 22, 2025 23:40
@larry-aptos larry-aptos merged commit d68d37e into main Jan 23, 2025
11 checks passed
@larry-aptos larry-aptos deleted the lightmark/account_abstraction-update-aptos-protos-update-sdk branch January 23, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants