Add columns to user_transactions table
#656
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
force-pushed
the
add_columns_to_user_transactions_table
branch
from
aecc42b to
097c733
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
=====================================
Coverage 48.0% 48.1%
=====================================
Files 232 232
Lines 27159 27207 +48
=====================================
+ Hits 13055 13103 +48
Misses 14104 14104 ☔ View full report in Codecov by Sentry. |
0xmaayan
force-pushed
the
add_columns_to_user_transactions_table
branch
from
097c733 to
f6af779
Compare
…transactions table
0xmaayan
force-pushed
the
add_columns_to_user_transactions_table
branch
from
f6af779 to
d7ed05e
Compare
rtso
reviewed
Jan 7, 2025
...db_output_files/user_transaction_processor/test_single_sender_webauth/user_transactions.json
Outdated
Show resolved
Hide resolved
...rc/db/postgres/migrations/2025-01-07-000504_add_function_columns_to_user_transactions/up.sql
Outdated
Show resolved
Hide resolved
|
nit on column naming - can we prefix the new columns with |
done |
0xmaayan
force-pushed
the
add_columns_to_user_transactions_table
branch
3 times, most recently
from
a270066 to
392ddff
Compare
0xmaayan
force-pushed
the
add_columns_to_user_transactions_table
branch
from
392ddff to
ecf5050
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://aptos-org.slack.com/archives/C03MN5F7WUV/p1734539332759199 , adding
contract_address,module_name, andfunction_namecolumns to theuser_transactionstable to index each of the entry function string data separately.