enable rebinding of G4HepEm random engine #438
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
SeverinDiederichs
force-pushed
the
enable_RNG_rebind
branch
from
2e22825 to
ebae3a6
Compare
JuanGonzalezCaminero
approved these changes
Sep 18, 2025
SeverinDiederichs
force-pushed
the
enable_RNG_rebind
branch
from
ebae3a6 to
7d052d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is needed for both Gauss and Athena to enable reproducibility. In both frameworks, the RNG engine is set to a different pointer for each event, therefore it requires a re-binding of the G4HepEm engine (see mnovak42/g4hepem#127)
With this PR, the results are reproducible again.
NOTE: does require a new tag of G4HepEm and updating the CI, therefore, this remains a draft for now.