Skip to content

fix(PIX-154): add TLS for Upstash Redis connections in worker and queue #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apsisvictor-sys wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(PIX-154): add TLS for Upstash Redis connections in worker and queue #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed1d62b
fix(worker): add TLS for Upstash Redis connection (PIX-154)
apsisvictor-sys Mar 25, 2026
6acdc5b
fix(redis-job-queue): add TLS for Upstash Redis connections (PIX-154)
apsisvictor-sys Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/infrastructure/jobs/redis-job-queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,12 @@ function getOrCreateRedisConnection(): IORedis {
}

const { host, port, password } = readRedisEnv();
// tls: {} is required for Upstash Redis (TLS-only endpoint, rediss:// scheme).
redisConnectionInstance = new IORedis({
host,
port,
password,
tls: {},
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Make TLS optional for non-Upstash Redis deployments

This change forces tls: {} on all Redis connections (getOrCreateRedisConnection, BullMQ queue connection, createRedisClient, and worker connection options), which turns every connection into TLS-only. The repository still includes a default deploy path that wires REDIS_HOST/REDIS_PORT from Railway RAILWAY_TCP_PROXY_* values (scripts/deploy/railway-provision-and-deploy.sh), so environments that are still plain TCP will regress from working to handshake failures, breaking queue enqueue/worker startup. Gate TLS with an explicit setting (or URL scheme) instead of hardcoding it for all Redis backends.

Useful? React with 👍 / 👎.

maxRetriesPerRequest: null,
retryStrategy: () => null
});
Expand All @@ -58,9 +60,10 @@ async function getQueue(): Promise<Queue> {
// Pass plain options to BullMQ so it uses its own internal ioredis instance.
// Avoids a TypeScript structural type conflict between top-level ioredis and
// the ioredis bundled inside bullmq/node_modules.
// tls: {} is required for Upstash Redis (TLS-only endpoint).
const { host, port, password } = readRedisEnv();
queueInstance = new Queue(JOB_QUEUE_NAME, {
connection: { host, port, password, maxRetriesPerRequest: null },
connection: { host, port, password, tls: {}, maxRetriesPerRequest: null },
defaultJobOptions: {
attempts: DEFAULT_ATTEMPTS,
backoff: { type: "exponential", delay: BACKOFF_DELAY_MS },
Expand Down Expand Up @@ -109,10 +112,12 @@ export function assertRedisJobConfiguration(): void {

export function createRedisClient(): IORedis {
const { host, port, password } = readRedisEnv();
// tls: {} is required for Upstash Redis (TLS-only endpoint).
return new IORedis({
host,
port,
password,
tls: {},
maxRetriesPerRequest: null,
retryStrategy: () => null
});
Expand Down
3 changes: 2 additions & 1 deletion src/infrastructure/jobs/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ export async function startJobsWorker(): Promise<void> {
// Pass plain options so BullMQ uses its own internal ioredis instance.
// Avoids a TypeScript structural type conflict between top-level ioredis
// and the ioredis bundled inside bullmq/node_modules.
const connectionOptions = { host, port, password, maxRetriesPerRequest: null as null };
// tls: {} is required for Upstash Redis (TLS-only endpoint).
const connectionOptions = { host, port, password, tls: {}, maxRetriesPerRequest: null as null };

new Worker(
getRedisQueueName(),
Expand Down