refactored product to get_product #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IrwinChay
commented
Jan 31, 2024
IrwinChay
commented
Jan 31, 2024
lkct
reviewed
Jan 31, 2024
lkct
force-pushed
the
symbolic_get_product
branch
from
f8d7e6d to
afc1f4c
Compare
IrwinChay
commented
Feb 8, 2024
| """Get the symbolic config to construct the product of this layer with the other layer. | ||
|
|
||
| Cases: | ||
| - Product with another HadamardLayer: layer config unchanged. \ |
There was a problem hiding this comment.
docstring: input layer > 2
There was a problem hiding this comment.
List Pre-requisite: expect inputs to match
lkct
reviewed
Feb 8, 2024
|
|
||
| Alternative usage: | ||
| - If performing product between product layer and sum-product layer, break the. \ | ||
| sum-product layer into sum and product layers beforehand. |
| - If performing product between product layer and sum-product layer, break the. \ | ||
| sum-product layer into sum and product layers beforehand. | ||
| - If pushing this layer into the input of the other layer instead, use. \ | ||
| other_layer.get_product(other_layer, this_layer, push_to_input=True). |
lkct
reviewed
Feb 13, 2024
IrwinChay
force-pushed
the
symbolic_get_product
branch
from
2515fef to
45f0895
Compare
lkct
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
get_product()currently support same scope product, have un-implemented templates for different scope product, the cases written with
TODOwould need to be discussed (ideally implement them in the actual layers, and keepreparam=self_symb_cfg.reparaminget_product()The cases without
TODOare not urgent and could be ignored for nowNote that to simplify
get_product()(avoid too many cases), callingself_layer.get_product()andother_layer.get_product()is different: e.g. ifself_layeris input layer andother_layeris product layer, should always callother_layer.get_product(),self_layer.get_product()in this case would raise an error.Discuss:
**Could you check if
id(cls)andid(CLASS_NAME)are different within the class methods? In my case the memory ids are different, so I only usedissubclass(other_symb_cfg.layer_cls, cls). Might be a potential bug? **Discuss how the
TODOwould be implemented, which are the different cases for different-scope-product we discussed earlier