-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product partition function #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The major problem is we should not make a Layer inside symbolic workflow. Yet we need to refer to self
in func for ParamConst.
Need further discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as below
c2cb302
to
d59f031
Compare
d59f031
to
04ef1f4
Compare
5bead0e
to
becf4ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after the commits above, just some minor things left.
for what's unresolved we discuss in other issues
Added product partition function, support more-than-two product (so that reparam structured in a binary tree)
Modified
binary.py
andfunctional.py
to support more-than-two productModified
categorical.py
to support partition function of the product of categorical layers (so Log-Sum-Exp is used instead of Log-Integ-Exp for categorical layers, but the code structure is still the same)TODO:
as a result of the design of
symb_cfg
, need to fetchnum_input_units
from the parameters in a clumsy way (indef get_integral()
ofprod_ef.py
), should we re-structuresymb_cfg
to simplify this?clean TODOs in
def get_partial()
, similar to the helper functions indef get_integral()
Could add tests for product partition function and more-than-two product, already tested locally