-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different scope product #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as below
@@ -0,0 +1,35 @@ | |||
# pylint: disable=too-many-locals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add to pyproject.toml? (possibly in another PR, also need to handle cache there)
Lines 147 to 149 in 53942db
per-file-ignores = [ # TODO: wait for native support in pylint | |
"/tests/:missing-function-docstring,missing-return-doc", | |
] |
82ac9f7
to
04122b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Thanks!
UPDATE: corrected
EFProductReparam
and
functional.py
and
is_compatible()
inregion_graph.py
(added: do not check compatibility when a partition is included in another partition)Tests for same scope product added
partition function for product added
TODO: fix
reset_parameters
, only reset the current level parameters, instead of "deep reset"(Current version: all parameters would be re-initialized whenever product is called)
TODO: in
prod_ef.py
, need to support product of multiple circuits, which is just extending ef1 and ef2 into a list of efsTODO: To actually support different scope product, we need scope renaming (urgent), e.g. circuit_1 have scope {0,1,2,3}; circuit_2 have scope {0,1,4,5};
, e.g.
forward()
intensorized_circuit.py
, currently it is indexing by scope (so not supporting circuit with scope {0,1,4,5})Better to discuss the class structure since it includes modifying a couple things
TODO: add to pyproject.toml in test.py