Fix progress bar "sticking", and fix "shallow" not defined (destructuring) on route #1
Open
mgoodfellow wants to merge 12 commits intoapproximant:mainfrom
Open
Fix progress bar "sticking", and fix "shallow" not defined (destructuring) on route #1mgoodfellow wants to merge 12 commits intoapproximant:mainfrom
mgoodfellow wants to merge 12 commits intoapproximant:mainfrom
Conversation
… route, also always cancel nprogress regardless of shallow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved issue where double progress bar/stuck progress bar (dont force finished as this causes the progress bar to show even if it wasn't running before)
When a route change is cancelled via an example call such as
router.events.emit('routeChangeError');, we can't destructure the obj as its not passed. It could be passed, but actually when cancelling the progress bar we don't care if it was shallow or not. Only when starting it