Improve logging of invalid AdMob App IDs #126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rabadash8820
force-pushed
the
log-admob-app-id
branch
from
ed4401d to
11835d6
Compare
|
Hey, @Rabadash8820! Thanks for bringing this to my attention. Sorry that the answer took so long. We plan to rework this whole system in Q4. I'll be sure to consider your input and add extra logging to make the failure easier to diagnose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code makes it difficult to tell what value the post-build script thinks is invalid. This is particularly relevant when working with other project-specific build scripts that might read the app ID from other sources, like an environment variable.