Replace possibly buggy FileUtils.mv with a two step solution#30
Open
emyl wants to merge 1 commit into
Open
Conversation
|
I also get this bug on both standalone and vagrant plugin. Would be nice to see it merged in and fixed. |
Author
|
@Zaylril in case you're interested, The following forks include the bug fix: https://github.com/emyl/librarian-chef-nochef |
Contributor
|
I want atomic rename. I don't want partially-copied directories. It looks like there is a bug with this description in some versions of Ruby: https://bugs.ruby-lang.org/issues/8109. Is this what you're running into? |
Author
|
Not really. After investigating a little bit more, I think that the issue could be caused by the virus scanner: https://www.ruby-forum.com/topic/1044813 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows 7/8 64bit, when using librarian-chef both standalone and trough vagrant, the
FileUtils.mvoperation fails withErrno::EACCES(permission denied). I suspect it could be a ruby bug, in any case it could be easily worked around.