Skip to content

make BaseSocketChannel less generic #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make BaseSocketChannel less generic #3419

wants to merge 1 commit into from
+81 −20

Conversation

@weissi
Copy link
Member

@weissi weissi commented Oct 22, 2025

Motivation:

I have seen a bunch of generic metadata instantiation in BaseStreamSocketChannel.bufferPendingWrite(data:promise:) and I think that's unnecessary.

Modifications:

  • Introduce a generic WriteType to BaseSocketChannel

Result:

  • Should do less with generic metadata as it's travelling less across the Channel class hierarchy.

@weissi weissi requested a review from Lukasa October 22, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lukasa Lukasa Awaiting requested review from Lukasa

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@weissi