Skip to content

Fix integer overflow in _checkCount(minimum:) #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
natecook1000 merged 1 commit into from
Aug 17, 2026
+12 −2
Merged

Fix integer overflow in _checkCount(minimum:) #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Sources/BinaryParsing/Parsers/Integer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
extension ParserSpan {
@inlinable
public func _checkCount(minimum: Int) throws(ParsingError) {
let requiredUpper = _lowerBound &+ minimum
guard requiredUpper <= _upperBound else {
guard count >= minimum else {
throw ParsingError(
status: .insufficientData,
location: startPosition)
Expand Down
11 changes: 11 additions & 0 deletions Tests/BinaryParsingTests/IntegerParsingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,4 +655,15 @@ struct IntegerParsingTests {
let result = try lebEncoded.withParserSpan { try Int(parsingLEB128: &$0) }
#expect(result == expected)
}

@Test
func checkCountDoesNotOverflow() throws {
try bigEndianOnes.withParserSpanIfAvailable { span in
// Consume some bytes so that `startPosition` is nonzero.
_ = try UInt32(parsingBigEndian: &span)
#expect(throws: ParsingError.self) {
try span._checkCount(minimum: .max)
}
}
}
}
Loading