-
Notifications
You must be signed in to change notification settings - Fork 23
Enable the embedded version of the libary #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b3da44e
Enable the embedded version of the libary
natecook1000 bc36146
Use typed throws for InlineArray parsers
natecook1000 50b80a7
Switch array parser to always use `ParsingError`
natecook1000 8465715
Formatting fix
natecook1000 306b5f0
Workaround missing arc4random symbol on Linux
natecook1000 3337858
Skip nightly-main linux
natecook1000 33785af
Merge branch 'main' into re-enable-embedded
natecook1000 b32bc81
Only use arc4random hack in embedded
natecook1000 c0af294
Don't use xcrun for macOS tests
natecook1000 92e2d56
Disable macOS test runner
natecook1000 b65cec8
Gate embedded targets behind compiler flag
natecook1000 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift Binary Parsing open source project | ||
| // | ||
| // Copyright (c) 2026 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import BinaryParsingEmbedded | ||
|
|
||
| @available(macOS 26.0, *) | ||
| @main | ||
| struct EmbeddedTest { | ||
| static func main() throws(ParsingError) { | ||
| let data: InlineArray<_, UInt8> = [0x0, 0x1, 0x2, 0x3, 0x4, 0x5] | ||
| var span = ParserSpan(data.span.bytes) | ||
|
|
||
| let a = try Int16(parsingBigEndian: &span) | ||
| let b = try Int16(parsingBigEndian: &span) | ||
| let c = try Int16(parsingBigEndian: &span) | ||
|
|
||
| precondition(a == 1) | ||
| precondition(b == 0x203) | ||
| print(c) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you need to bump these deployment targets back up? Were they wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the embedded target added I get this error when I build locally:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drat. This undoes some of the improvement from #47. I don't know of a good way around it, though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ended up needing to conditionalize the embedded support anyway, so the platforms are reset in the default case! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!