Add extracting APIs that reset span bounds - #36
Merged
Merged
Conversation
This change adds three `ParserSpan.extracting` APIs that yield new `ParserSpan` instances that have their internal span boundaries shrunk to fit, instead of just insetting the boundaries at the `ParserSpan` level. An extracted span can be passed off to a parsing function without worry that an absolute seek will go beyond the visible boundaries of the span.
natecook1000
marked this pull request as ready for review
September 10, 2025 18:54
Member
Author
|
Re: naming, I went with |
numist
approved these changes
Sep 16, 2025
numist
left a comment
There was a problem hiding this comment.
/// An _extracted_ parser span doesn't retain information about the bounds of
/// the original span…
Love it. This interface is going to be a big improvement for container formats (or formats that use framing), where child parsers should be restricted to their own range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds three
ParserSpan.extractingAPIs that yield newParserSpaninstances that have their internal span boundaries shrunk to fit, instead of just insetting the boundaries at theParserSpanlevel. An extracted span can be passed off to a parsing function without worry that an absolute seek will go beyond the visible boundaries of the span.Checklist
Scripts/format.shto correctly format my change