-
Notifications
You must be signed in to change notification settings - Fork 341
Support async custom completion closures #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support async custom completion closures #782
Conversation
9916bb6
to
9a298ff
Compare
@natecook1000 This PR should be simpler to review than #764, so you might want to get this out of the way first. Thanks for reviewing / merging everything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you add a couple tests that verify that the async version is usable?
@natecook1000 Added a multi-shell custom completion test for async custom completion handlers. Thanks for reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@swift-ci Please test
@swift-ci Please test |
@natecook1000 I pushed an attempt to fix the Linux build issues. I didn't get any build or test issues on macOS 15.5, but I don't know how to run the Linux tests myself, or how to make the macOS tests mimic the Linux tests. I assume that the Linux tests have stricter concurrency checking enabled than the macOS & Windows tests do. Maybe they should be changed to be as strict as the Linux tests. Should I open an issue for that? Does one already exist? |
d1732af
to
020dfd3
Compare
@natecook1000 Is there any way to get this into 1.5.1? I fixed the issue with the Linux tests, so it should be good to go. Thanks. |
Signed-off-by: Ross Goldberg <[email protected]>
Signed-off-by: Ross Goldberg <[email protected]>
Signed-off-by: Ross Goldberg <[email protected]>
020dfd3
to
d4581a2
Compare
@natecook1000 Sorry, I just noticed that 1.5.1 only includes the small patch, not all the changes for completions, etc. I was so worried that these 2 PRs wouldn't get in the new release that I hurried to rebase & comment before completely understanding what was in 1.5.1. I also wondered why it was 1.5.1 instead of 1.6.0, but now I know. Sorry for the misunderstanding. Looking over the unreleased notes now. |
@swift-ci Please test |
Support async custom completion closures.
Resolve #555
Checklist