Update license year #871
Merged
Update license year #871
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bioball
force-pushed
the
license-year-update
branch
from
6e884e0 to
6d63bd9
Compare
* Update license header file spec to use placeholder year * Update spotless to use ratchet formatting (only format files that have changed)
bioball
force-pushed
the
license-year-update
branch
from
6d63bd9 to
a150917
Compare
bioball
commented
Jan 2, 2025
| spotless { | ||
| ratchetFrom = "$originalRemoteName/main" |
There was a problem hiding this comment.
I'd love to just say "the remote whose URL is [email protected]:apple/pkl.git", but it doesn't look like Spotless supports this.
There was a problem hiding this comment.
You'd also need to account for HTTPS remotes in that case, which can get messy :(
stackoverflow
approved these changes
Jan 6, 2025
bioball
added a commit
to bioball/pkl
that referenced
this pull request
Jan 17, 2025
* Update license header file spec to use placeholder year * Update spotless to use ratchet formatting (only format files that have changed)
bioball
added a commit
that referenced
this pull request
Jan 17, 2025
* Update license header file spec to use placeholder year * Update spotless to use ratchet formatting (only format files that have changed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy new year!
This adds logic to update the license header year only when source code files change.
For new files, they will receive the current year as the license year.
For existing files, they will receive a range from the initial year to the current year (e.g. 2024-2025 for the set of files currently in the repo).
For those like me that call apple/pkl something other than "origin", set the env var
PKL_ORIGINAL_REMOTE_NAMEwhen developing locally. Personally, I have setPKL_ORIGINAL_REMOTE_NAME=upstream.