Implement SPICE-0009 External Readers #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HT154
force-pushed
the
external-readers
branch
from
96606d9 to
eaed08f
Compare
HT154
force-pushed
the
external-readers
branch
from
eaed08f to
e1f24be
Compare
HT154
force-pushed
the
external-readers
branch
from
e1f24be to
1f7daa3
Compare
HT154
force-pushed
the
external-readers
branch
from
5ed4926 to
a1763f4
Compare
…eader with null arguments
HT154
force-pushed
the
external-readers
branch
from
b4a209e to
1ab5471
Compare
HT154
commented
Jan 14, 2025
Comment on lines
+335
to
+339
| case let bytes as [UInt8]: | ||
| guard type(of: value) == [UInt8].self else { | ||
| fallthrough | ||
| } | ||
| try self.encode(bytes) |
There was a problem hiding this comment.
In Swift, empty arrays succeed for dynamic casting operations to other array types (Array<T>() is Array<U> == true). In order to correctly fall through for empty non-UInt8 array an additional type comparison using type(of:) is required. For the fallthrough to work correctly this case must directly precede the default case.
HT154
commented
Jan 14, 2025
|
This should be all set now! Probably best to merge after apple/pkl#882 lands, gets backported, and Pkl 0.27.2 is published and added to pkl-swift CI. |
bioball
requested changes
Jan 15, 2025
Comment on lines
+335
to
+339
| case let bytes as [UInt8]: | ||
| guard type(of: value) == [UInt8].self else { | ||
| fallthrough | ||
| } | ||
| try self.encode(bytes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPICE-0009
EvaluatorOptions.externalModuleReadersandEvaluatorOptions.externalResourceReaders.ExternalReaderClientto host the child process side of the external reader workflow.