Fix constraint in Probe #14
Conversation
Add grpc to the set of possible properties
generated-package/K8sObject.pkl
Outdated
| @@ -131,6 +131,10 @@ const function hasNonNullPortNames(l: Listing): Boolean = (l.length > 1).implies | |||
| const function exactlyOneSet(a: Any, b: Any, c: Any) = | |||
| (a != null).xor(b != null).xor(c != null) && !(a != null && b != null && c != null) | |||
|
|
|||
| /// Tells if exactly one of the four arguments is non-null. | |||
| const function exactlyOneSet4(a: Any, b: Any, c: Any, d: Any) = | |||
| (a != null).xor(b != null).xor(c != null).xor(d != null) && !(a != null && b != null && c != null && d != null) | |||
There was a problem hiding this comment.
I think this will return true if 3/4 are true
There was a problem hiding this comment.
pkl1> a = null; b = "x" ; c = 2 ; d = true
pkl2> (a != null).xor(b != null).xor(c != null).xor(d != null) && !(a != null && b != null && c != null && d != null)
true
There was a problem hiding this comment.
Good catch, updated.
I don't know if there's a simpler way to write this expression asides from my updated version; feel free to provide a suggestion
There was a problem hiding this comment.
You could do a summation of a != null ? 1 : 0 + ... == 1 but I'm not sure if that comes out simpler or more readable
| /// Tells if exactly one of the four arguments is non-null. | ||
| const function exactlyOneSet4(a: Any, b: Any, c: Any, d: Any) = | ||
| (a != null && b == null && c == null && d == null) | ||
| || (a == null && b != null && c == null && d == null) | ||
| || (a == null && b == null && c != null && d == null) | ||
| || (a == null && b == null && c == null && d != null) | ||
|
|
There was a problem hiding this comment.
| /// Tells if exactly one of the four arguments is non-null. | |
| const function exactlyOneSet4(a: Any, b: Any, c: Any, d: Any) = | |
| (a != null && b == null && c == null && d == null) | |
| || (a == null && b != null && c == null && d == null) | |
| || (a == null && b == null && c != null && d == null) | |
| || (a == null && b == null && c == null && d != null) | |
| /// Tells if exactly one of the arguments is non-null. | |
| local function exactlyOneSet(args: List<Any>): Boolean = | |
| args.fold(0, (i, arg) -> if (arg != null) i + 1 else i) == 1 |
You can remove the other exactlyOneSet and only have this one.
This would be a prime candidate for varargs once we support it.
There was a problem hiding this comment.
I'd rather avoid the allocation here. But, we should really have better support for mutual exclusion; maybe a good candidate to add to pkl:base
Add grpc to the set of possible properties