Implement container stats #851
Open
+777
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements statistics gathering across the various components, but ultimately this is for implementing a new CLI command: `container stats`. This shows memory usage, cpu usage, network and block i/o and the number of processes in the container. The new command can inspect stats for 1-N containers and by default continuously updates in a `top` like stream.
dcantah
force-pushed
the
container-stats
branch
from
002f619 to
2c386f4
Compare
jglogan
reviewed
Nov 14, 2025
| memoryUsageBytes: stats.memory.usageBytes, | ||
| memoryLimitBytes: stats.memory.limitBytes, | ||
| cpuUsageUsec: stats.cpu.usageUsec, | ||
| networkRxBytes: stats.networks.reduce(0) { $0 + $1.receivedBytes }, |
Contributor
There was a problem hiding this comment.
Would it be more useful to only reduce these at the command line and make all of these fields arrays? If we did can the caller correlate the entries readily with the config?
| @Option(name: .long, help: "Format of the output") | ||
| var format: ListFormat = .table | ||
|
|
||
| @Flag(name: .long, help: "Disable streaming stats and only pull the first result") |
Contributor
There was a problem hiding this comment.
How about a stream argument that's an enumeration of follow and top (which might not be 100% sensical now but becomes more so if we add arg-based or interactive sort).
| public init() {} | ||
|
|
||
| public func run() async throws { | ||
| if format == .json || noStream { |
Contributor
There was a problem hiding this comment.
json + top doesn't make sense, but json + follow would give you JSONL/NDJSON output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #824
This implements statistics gathering across the various components, but ultimately this is for implementing a new CLI command:
container stats. This shows memory usage, cpu usage, network and block i/o and the number of processes in the container. The new command can inspect stats for 1-N containers and by default continuously updates in atoplike stream.Type of Change
Testing