Fix image save to default to current platform when no platform specified #725
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When saving images without specifying --platform, --arch, or --os flags, the command now defaults to the current platform instead of failing with a notFound error. Fixes apple#712
Contributor
Author
|
Hi @katiewasnothere, can you have a look at this pr :) |
Contributor
|
Hi @bismansahni, sorry for the delay and thank you for the contribution! I know we have an open issue here to push/pull the current platform by default. I see there's a PR for that here, which may be out of date and need to be updated. Based on the comment in that PR, I'm wondering if it would be better for us to do that change and this change at the same time so we can keep the behavior consistent between image What do you think? I'm open to other thoughts on the approach here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #712 where
container image savecommand fails with a notFound error when no platform options are specified.The fix adds a default to use the current platform when
--platform,--arch, and--osflags are all unspecified, preventing the platform variable from being nil.Changes
ImageSave.swiftto default toPlatform.currentwhen no platform options are providedTest plan
container image savenow works without platform flagsFixes #712