Use custom upload ID on Android (MITM-706) #13
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karthz
approved these changes
Jul 27, 2023
android/src/main/java/com/appfolio/uploader/ModifiedHttpUploadRequest.kt
Show resolved
Hide resolved
hojason117
force-pushed
the
mitmAndroidUseCustomUploadId
branch
from
6a8d8a5 to
5a55065
Compare
hojason117
changed the title
hojason117
changed the title
Co-authored-by: Karthik Subramaniam <karthik@appfolio.com>
hojason117
force-pushed
the
mitmAndroidUseCustomUploadId
branch
from
5a55065 to
28cfa3f
Compare
|
🎉 This PR is included in version 6.11.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously on Android,
customUploadIdwasn't used throughout the upload process due toModifiedHttpUploadRequestandUploadRequesthaving their ownuploadId, and this resulted in thecompletedlistener being called on a different UUID than the one given tostartUpload.This PR ensures that the
customUploadIdused tostartUploadis the one called in the listeners.