Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Expo SDK 50 Build Issues. #15

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix Expo SDK 50 Build Issues. #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
apply plugin: 'com.android.library'

def safeExtGet(prop, fallback) {
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

android {
compileSdkVersion 28
buildToolsVersion "28.0.3"
compileSdkVersion safeExtGet("compileSdkVersion", 28)
buildToolsVersion safeExtGet("buildToolsVersion", "28.0.3")

defaultConfig {
minSdkVersion 21
targetSdkVersion 28
minSdkVersion safeExtGet("minSdkVersion", 21)
targetSdkVersion safeExtGet("targetSdkVersion", 28)
versionCode 1
versionName "1.0"
ndk {
abiFilters "armeabi-v7a", "x86"
}
}
lintOptions {
warning 'InvalidPackage'
warning 'InvalidPackage'
}
}

Expand Down
4 changes: 0 additions & 4 deletions ios/ReactNativePayments.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@
@import PassKit;
@import AddressBook;

#if __has_include("RCTBridgeModule.h")
#import "RCTBridgeModule.h"
#else
#import <React/RCTBridgeModule.h>
#endif

#import "GatewayManager.h"

Expand Down
6 changes: 5 additions & 1 deletion react-native-payments.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,9 @@ Pod::Spec.new do |s|
s.requires_arc = true

s.dependency 'React'
s.dependency 'Stripe', '~> 19'

# Stripe support on this fork is completely untested. This change to depend on
# stripe 23 is to fix simulator build issues in our app. We do not use stripe,
# and I make no guarantee that this works.
s.dependency 'Stripe', '~> 23'
end
Loading