Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set user email field type #4878

Merged
merged 3 commits into from
Mar 21, 2025
Merged

set user email field type #4878

merged 3 commits into from
Mar 21, 2025

Conversation

ETLaurent
Copy link
Contributor

@ETLaurent ETLaurent commented Mar 10, 2025

Summary

Would this create possible regressions?

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@ETLaurent ETLaurent marked this pull request as ready for review March 10, 2025 14:11
@ETLaurent
Copy link
Contributor Author

ETLaurent commented Mar 10, 2025

@ETLaurent ETLaurent requested a review from boutell March 10, 2025 14:32
boutell
boutell previously approved these changes Mar 10, 2025
Copy link
Member

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not. It definitely qualifies as fixing a bug and it is more secure. I'll take the heat if anyone has concerns on this one.

@ETLaurent ETLaurent added the don't merge yet This PR is meant to be merged, but not right away label Mar 10, 2025
@ETLaurent ETLaurent requested a review from boutell March 20, 2025 14:51
@ETLaurent ETLaurent removed the don't merge yet This PR is meant to be merged, but not right away label Mar 20, 2025
@ETLaurent ETLaurent merged commit 1c6a26e into main Mar 21, 2025
9 checks passed
@ETLaurent ETLaurent deleted the user-email-type branch March 21, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants