Security improvements - #19
Merged
Merged
Conversation
An attacker could rotate the leftmost X-Forwarded-For value to land every request in a fresh bucket, bypassing the only brute-force control on login, register, and invite redemption (TASK-088). The limiter now trusts a single proxy-set header (default X-Real-IP, overridable via PARTS__RATELIMIT__CLIENT_IP_HEADER for a future CDN edge); the generated Caddyfiles delete any client-supplied X-Real-IP and set it from the real peer. Absent header falls back to :remote-addr — one shared bucket, over-throttling rather than a bypass.
An authenticated session could silently rotate the login email or password — brief access to a session (shared device, session theft) meant full account takeover or lockout (TASK-090). update-account now demands a correct :current_password whenever the body touches :email or :password (step-up re-auth via auth/current-password-valid?, which checks the stored hash directly since user/fetch strips it). Display-name-only updates are unaffected. New-email ownership confirmation and old-address notification remain open pending the transactional mail layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening the heck out of this thing