Add timeouts and connection health checks to Redis connections #7526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in #7354 by @aembke.
Changes included in this PR:
fred
to 10.1.0fred
configuration to improve client resiliency under various failure modes (TCP failures and timeouts, unresponsive sockets, Redis server failures, etc)RecvError::Lagged
(which can happen reader end of the channel is too slow)Note: this PR removes the timeout on
wait_for_connect
inRedisCacheStorage::create_client
. Theinternal_command_timeout
andunresponsive
config fields should handle timeouts on connection creation, so hopefully that's not necessary.Fixes #6855
Fixes #7354
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩