Skip to content

Conversation

@mo4islona
Copy link

@mo4islona mo4islona commented Jan 8, 2025

Fixes #8013

@apollo-cla
Copy link

@mo4islona: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Jan 8, 2025

✅ Docs Preview Ready

No new or changed pages found.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 8, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@glasser
Copy link
Member

glasser commented Jan 8, 2025

I think it would be more extensible to add a validateOptions option similar to the existing parseOptions. It's a bit awkward that graphql-js does not export a ValidationOptions TS interface, but you could use Parameters<typeof validate>[3] or something.

@mo4islona mo4islona force-pushed the main branch 2 times, most recently from 8c481ea to 380f07b Compare January 8, 2025 19:56
@mo4islona
Copy link
Author

I think it would be more extensible to add a validateOptions option similar to the existing parseOptions. It's a bit awkward that graphql-js does not export a ValidationOptions TS interface, but you could use Parameters<typeof validate>[3] or something.

Implemented.

@glasser
Copy link
Member

glasser commented Jul 3, 2025

This looks like a good improvement (very similar to #8062). It is backwards-compatible, so I'm not going to rush to get it in before releasing v5. It needs docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support validation "maxErrors" option

5 participants