Skip to content

fix: SelectionSet equality in 1.x #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 8, 2025
Merged

fix: SelectionSet equality in 1.x #771

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2ea0796
Refactor SelectionSet equality to recover type data
calvincestari Sep 24, 2025
bfeb4c4
Adds equality tests
calvincestari Sep 24, 2025
8a53f79
Adds another test for type cast edge case
calvincestari Sep 24, 2025
d417bee
Fix incorrect DataDict test key names
calvincestari Sep 25, 2025
57526e6
Refactor type casting
calvincestari Sep 25, 2025
469ef00
Fix for nullable objects being null in equality checks
calvincestari Sep 27, 2025
7ae6874
Add integration test
calvincestari Sep 27, 2025
f28dff6
Refactor scalar casting logic for nullable object types
calvincestari Sep 29, 2025
cc8a2de
Refactor scalar casting logic for lists
calvincestari Sep 29, 2025
df986c5
Fix and add tests
calvincestari Sep 29, 2025
893a4f5
Remove test mock infrastructure hash and equality implementations
calvincestari Sep 29, 2025
62f5c2b
Additional test using pagination problem model
calvincestari Oct 7, 2025
ab8f785
Refactor equality logic
calvincestari Oct 7, 2025
14598bd
Remove @disfavoredOverload annotation
calvincestari Oct 8, 2025
80e7ccf
Clean up test
calvincestari Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions Tests/ApolloInternalTestHelpers/MockOperation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,6 @@ open class AbstractMockSelectionSet<F, S: SchemaMetadata>: RootSelectionSet, Has
public subscript<T: MockSelectionSet>(dynamicMember key: String) -> T? {
__data[key]
}

public static func == (lhs: MockSelectionSet, rhs: MockSelectionSet) -> Bool {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SelectionSet now has it's own equality implementation.

lhs.__data == rhs.__data
}

public func hash(into hasher: inout Hasher) {
hasher.combine(__data)
}
}

public typealias MockSelectionSet = AbstractMockSelectionSet<NoFragments, MockSchemaMetadata>
Expand Down
Loading
Loading